feat(tournaments-ticker): add new redesigned ticker with variants for AB testing#7303
feat(tournaments-ticker): add new redesigned ticker with variants for AB testing#7303
Conversation
The tournament list ticker should always reset to Ongoing on page load. Removes syncLevel from ContentSwitch entirely and sets storeValue=false in the List widget so no tab state is persisted to localStorage.
ElectricalBoy
left a comment
ElectricalBoy
left a comment
There was a problem hiding this comment.
lgtm; comments are optional
| link = tournament.pageName, | ||
| options = {noTemplate = true}, | ||
| } | ||
| or Icon{iconName = 'firstplace', size = '1.125rem'} |
There was a problem hiding this comment.
Should this rather be in LeagueIcon.display, replacign the current FILLER icon?
There was a problem hiding this comment.
Hmm, so downloading the icon SVGs as black and white variants, uploading both to LP, replacing the FILLER with them with the theming logic?
There was a problem hiding this comment.
Ah, actually the FILLER in LeagueIcon is a blank image. Disregard that then.
However, IMO we should be consistent, and not display a placeholder here as well if theres no icon.
There was a problem hiding this comment.
Yeah I didn't realize the FILLER icon even existed and trying to think how we should solve this. Maybe we make the LeagueIcon.display return string (if image) or Widget (if placeholder trophy icon)?
There was a problem hiding this comment.
This seems to work
There was a problem hiding this comment.
This will affect all other places where LeagueIcon is used. Is that really intended?
I don't see an issue with not having an icon when there's none for a tournament.
There was a problem hiding this comment.
tested on result table too, looks alright to me
There was a problem hiding this comment.
However, IMO we should be consistent, and not display a placeholder here as well if theres no icon.
Oh I actually misread this backwards. Thought you meant we should display it everywhere. I agree we should go with either no icon or icon everywhere.
@PiddyNydra what do you think?
There was a problem hiding this comment.
Agreed with @mbergen, I think noicon is fine indeed
Summary
This PR introduces the redesigned tournament ticker for mainpages. We're rolling this out on a couple wikis first, so we're not going to replace the existing ticker before it's rolled out everywhere. This PR:
Widget/Tournaments/Ticker/Listwith a tab-based phase navigation variant (default) and a collapsible variant (AB test - will most likely settle for one)subtletier pill variant with configurablecolorScheme(full/top3) (Tier colors is AB test - will most likely settle for one)Widget/Tournaments/Ticker/DatamoduleChevronTogglefromWidget/Participants/Team/toWidget/GeneralCollapsible/for broader reuseNotes
stylesheets/commons/TournamentTags.scsshas hardcoded hex values. My thinking was doing the AB test like this, and make variables to skin when we settle on the approach to avoid double work.How did you test this change?
|dev=ntlon the mainpages of wikis listed below + devtoolsVariants: